Repository navigation
Conversation
A table level [CONSTRAINT [symbol]] CHECK (expr) definition was reported as a column named CHECK, and the rest of the statement was lost. Parse it as a create definition with the CHECK option. Ref phpmyadmin#167 Signed-off-by: Магда М.Г. <mail@mgmagda.ru>
by-ae
reviewed
Oct 28, 2026
There was a problem hiding this comment.
Checked this out and ran phpunit on the branch: 1065 tests, all pass.
I also fed it a few real SHOW CREATE TABLE shapes that aren't in the new fixture, and they all parse with no errors and build back unchanged:
- MySQL 8 output with doubled parens and the version comment:
CONSTRAINT `chk` CHECK ((`a` < `b`)) /*!80016 NOT ENFORCED */builds asCONSTRAINT `chk` CHECK ((`a` < `b`)) NOT ENFORCED. On 5.11.x the same statement gives 4 errors and drops the constraint. - MariaDB output that mixes a column-level
CHECK (json_valid(`j`))with a table-levelCONSTRAINT `CONSTRAINT_1` CHECK (`a` > 0). - Nested parens in an unnamed check,
CHECK (a IN (1,2) AND (b > 0)), followed by another column. CONSTRAINT c1 CHECK (a > 0) ENFORCED, andCONSTRAINT CHECK (...)followed byPRIMARY KEY (a).
Since the check constraint now shows up in $statement->fields with no type or key, I made sure the helpers in Utils\Table still behave. On a table that has a FOREIGN KEY and a CHECK constraint, Table::getFields() returns just the real columns (j,a,b) and Table::getForeignKeys() returns only fk, the same as on 5.11.x. Both skip entries with an empty type/key, so the new entry doesn't leak into either one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #167
A table level check constraint broke parsing of the whole
CREATE TABLE, with any context (MySQL 8.0.16+ and MariaDB 10.2.1+ both print it inSHOW CREATE TABLE):Before:
and
build()gaveCREATE TABLE t (`a` int, `b` int): the constraint and columncwere lost. The same happens for an unnamedCHECK (a > 0)and forCONSTRAINT CHECK (...).Now
CreateDefinitionaccepts[CONSTRAINT [symbol]] CHECK (expr)and stores it like a column check:nameis the constraint symbol (or null),isConstraintis set forCONSTRAINT, and the expression is inoptions(the existingCHECKfield option, so[NOT] ENFORCEDworks too).Utils\Table::getFields()skips it because it has no type.Column level
CHECKandALTER TABLE ... ADD CONSTRAINT ... CHECKare not changed.Docs:
Tests: parser fixture
parseCreateTableCheckConstraint(named, unnamed,CONSTRAINT CHECK,NOT ENFORCED, the example from #167, a column after the constraints) and a round-trip test intests/Builder/CreateStatementTest.php.